Non-static error messages

[Dag Arneson]

Nico,
We considered that patch, but rejected it because it broke
compatibility with PHP 4.  PHP 4 still represents over half of the PHP
installations in the wild, and so we think that it's important to
remain compatible.  PHP 5 still works with the library, even though it
spits out warnings.

Dag

On Thu, May 29, 2008 at 2:03 PM, Nicolas Toper <nicolas.toper at af83.com> wrote:
> Hi,
>
> I have submitted a patch for that.
>
> Nico
>
> Le 29 mai 08 à 22:55, Jonathan Daugherty a écrit :
>
>>> Yes, these messages are going to the log file, not the browser.
>>> That is
>>> still a problem, however. It makes the library look broken and
>>> makes it
>>> hard to find other error messages because there are so many OpenID
>>> warnings.
>>
>> The library is written to work with PHP 4 and 5.  As a PHP 4 library,
>> it is going to generate some warnings on PHP 5.  Since some changes to
>> eliminate those warnings would often be syntactically invalid PHP 4,
>> the only solution right now is to log them to a place that the user
>> doesn't see.  Any program that logs its warnings to the browser is
>> going to look "broken."  But as I said before, the library does work
>> on PHP 5 so the warnings you're seeing should be non-fatal.
>>
>>> If anyone has any suggestions for changes to the library code to
>>> make it
>>> a bit more PHP 5 friendly, I'd appreciate it!
>>
>> There have been several requests to make the library more
>> PHP5-friendly.  I would be more than happy to consider patches that do
>> so without breaking the library on PHP 4.  Maybe there are some
>> php.ini things one could tweak to make it a little more forgiving.
>>
>> To see a list of PHP versions against which we run the tests, check
>> out the buildbot at
>>
>>   http://openidenabled.com:8011/
>>
>> I just created a ticket for this kind of issue and I'll try to get
>> this written up soon:
>>
>>   http://trac.openidenabled.com/trac/ticket/180
>>
>> --
>>  Jonathan Daugherty
>>
>> _______________________________________________
>> Dev mailing list
>> Dev at lists.openidenabled.com
>> http://lists.openidenabled.com/mailman/listinfo/dev
>
> Nicolas Toper | AF83
> 42, boulevard de Sébastopol | 75003 Paris | France
> 1436 A, Howard Street | San Francisco 94107, CA | USA
> Web : www.af83.com | Skype :ntoper_bs2
>
> This email is: [ ] bloggable [ ] ask first [X] private
>
>
>
>
>
> _______________________________________________
> Dev mailing list
> Dev at lists.openidenabled.com
> http://lists.openidenabled.com/mailman/listinfo/dev
>