darcs patch: Consumer#complete can accept a rails CgiRequest object

[Kevin Turner]

Thanks Jesse, but doesn't this cause a "NameError: uninitialized
constant", as we don't require ActionController in that module?

+        if(query_or_request_object.is_a?
ActionController::AbstractRequest)

In general, we won't be putting Rails code in OpenID::Consumer.  But
perhaps we'll create an adapter class.  Or ideally someone would
maintain something that actually integrates more with the conventional
rails user/session module.

Regardless, your example is a good one, and we should update our
included examples accordingly.  Do you know offhand if this of request.*
does thing we want it do to when the application is behind a reverse
proxy or fastcgi server?



On Fri, 2008-02-08 at 17:52 -0800, Jesse A Wolfe wrote:
> So it turns out that the best way to use OpenID::Consumer#complete in
> rails is to call:
>   consumer.complete(request.query_parameters, request.protocol +
> request.host_with_port + request.request_uri)
> and that's awkward. so here's a patch to allow
>   consumer.complete(request)
> 
> 
> ---------- Forwarded message ----------
> From: Jesse Wolfe <jes5199 at gmail.com>
> Date: Feb 8, 2008 5:50 PM
> Subject: darcs patch: Consumer#complete can accept a rails CgiRequest object
> To: jes5199 at jes5199.com
> 
> 
> Fri Feb  8 17:17:53 PST 2008  Jesse Wolfe <jes5199 at gmail.com>
>   * Consumer#complete can accept a rails CgiRequest object